Not really. I doubt anyone takes up smoking because Ben Grimm or Nick Fury do it, but whatever. It's their comics... Personally, I don't have any problem with characters smoking and have characters smoke in my comics where I think it useful, but they're under no obligation to follow my rules...
It was even a part of the canon that he was immune to the cancerous effects of smoking due to his healing factor. His smoking was an element of his character, in that it served as a foil for certain characters and a personality element for Logan (he is/was the sort of person who would light up in a hospital if he felt like it).
"Outside of a dog, a book is a man's best friend. Inside a dog, it's too dark to read"- Groucho Marx
part of his character is trying to be a regular human, and often doing a sucky job of it, coming off as an ass is a situation that comes out of that. he's a good person, just kinda rude without realizing it.
at least that's what i think, it depends on who is writing him really.